Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightgbm v4.6.0 #70

Merged
merged 9 commits into from
Feb 19, 2025
Merged

lightgbm v4.6.0 #70

merged 9 commits into from
Feb 19, 2025

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 15, 2025

Updates to lightgbm v4.6.0, which I just released to PyPI:

Also proposes moving patches into a patches/ directory and numbering them, similar to watch is done in arrow-cpp-feedstock: https://github.com/conda-forge/arrow-cpp-feedstock/tree/main/recipe/patches. I think that is helpful as the number of patches grows in the future.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jameslamb
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 15, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13342764913. Examine the logs at this URL for more detail.

@@ -80,7 +80,7 @@ outputs:
- dask >=2.0.0
- pandas >=0.24.0
- pyarrow >=6.0.1
- scikit-learn !=0.22.0
- scikit-learn >=0.24.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameslamb jameslamb mentioned this pull request Feb 15, 2025
32 tasks
@jameslamb
Copy link
Member Author

Ok after a bit of fidgeting with the patches, I think this is working. Will leave it up for a few days until another maintainer has a chance to review.

@jameslamb jameslamb mentioned this pull request Feb 15, 2025
3 tasks
@jameslamb
Copy link
Member Author

This has been up for a couple days and I think the changes are non-controversial, so going to put this in. Please @ me if you see any issues and I'll fix them in a follow-up.

@jameslamb jameslamb merged commit 9d8161d into conda-forge:main Feb 19, 2025
15 checks passed
@jameslamb jameslamb deleted the v4.6.0 branch February 19, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants