Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable QtWinExtras for Windows Build #86

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

n-elie
Copy link
Contributor

@n-elie n-elie commented Sep 15, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@mingwandroid
Copy link
Contributor

Did you test this? It doesn't work. There's a typo in QtWinExtas, also you are enabling QtSerialPort in this.

@n-elie
Copy link
Contributor Author

n-elie commented Sep 15, 2020

I was not able to test because pyqt source code is not available at the given adress anymore. Also, QtSerialPort was already enabled.

@n-elie
Copy link
Contributor Author

n-elie commented Sep 15, 2020

Would it be allowed to use archive.org to get the source code?

@jschueller
Copy link
Contributor

@n-elie n-elie marked this pull request as draft September 15, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants