Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin numpy as a host dep #89

Closed
wants to merge 6 commits into from

Conversation

MilesCranmer
Copy link
Contributor

Continuation of #85

cc @h-vetinari @ngam @mkitti

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@MilesCranmer
Copy link
Contributor Author

@mkitti
Copy link
Contributor

mkitti commented Jun 6, 2023

What is the load error to begin with? Set LD_DEBUG=libs for Linux.

@ngam
Copy link
Contributor

ngam commented Jun 6, 2023

Do you need the newest numpy? What’s the issue?

@MilesCranmer
Copy link
Contributor Author

Not sure. I think if I fix the libdstdcxx-ng to an earlier version the error goes away (IIRC).

Here's a run with LD_DEBUG=libs (just started)

@h-vetinari
Copy link
Member

h-vetinari commented Jun 6, 2023

Damn, still broken: https://github.com/MilesCranmer/PySR/actions/runs/5192076497

You have a completely separate issue there; it looks like it's scipy, but it's not. I've tested it, it works fine with libstdcxx 13. It might however be influenced if something similar to the numpy situation is happening for scipy (e.g. reinstalling it through julia).

@h-vetinari
Copy link
Member

h-vetinari commented Jun 6, 2023

Rather than a two-step setup, why not include the relevant testing from https://github.com/MilesCranmer/PySR (AFAICT python -m pysr.test main; with whatever preparations are necessary) here?

@ngam
Copy link
Contributor

ngam commented Jun 7, 2023

+1 on fully testing here. You can do the tests again nightly in the project’s repo, but we should a thorough test here

@MilesCranmer
Copy link
Contributor Author

Added. I'm trying again with the numpy pinning just to fix the conda build.

If I want to constrain libstdcxx-ng'<13', I guess I should add that to host:?

@h-vetinari
Copy link
Member

If I want to constrain libstdcxx-ng'<13', I guess I should add that to host:?

You would have to add it under run_constrained:. But it shouldn't be necessary, so I'd be interested how it fails without that pin.

Comment on lines +22 to 24
# Temporary fix for PyCall.jl mistakenly re-installing numpy.
# TODO: Remove this.
- numpy >=1.24.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other question I have here is: why are the other packages (pandas, sympy, scikit-learn) included in host?

@ngam
Copy link
Contributor

ngam commented Jun 8, 2023

@MilesCranmer, please utilize the bot rerender services, e.g. @conda-forge-admin, please rerender

@ngam
Copy link
Contributor

ngam commented Jun 8, 2023

The larger problem here may lie in the pre-compilation step. I have grown somewhat discouraged by Julia's Pkg design when it comes to third-party packaging (like here). It's simply too insular for the time being...

I also thought this post was quite interesting about how the whole gig works: https://discourse.julialang.org/t/the-present-and-the-future-of-package-registration/99890

@ngam
Copy link
Contributor

ngam commented Jun 8, 2023

Experimenting in #90. There seem to be issues the precompilation

@mkitti
Copy link
Contributor

mkitti commented Jun 8, 2023

I also thought this post was quite interesting about how the whole gig works: https://discourse.julialang.org/t/the-present-and-the-future-of-package-registration/99890

What does that have to do with this?

It's basically analgous to a conda channel. We can create our own registry:
https://github.com/GunnarFarneback/LocalRegistry.jl

I just don't want to run it.

@MilesCranmer
Copy link
Contributor Author

Superseded by #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants