Tests for version, use conda-build for download/check #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to source binaries and check checksums instead of python/curl, add maintainer
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Sorry about all the noise on there: looks like we have happy builds now :) |
igortg
approved these changes
Jan 14, 2019
| @@ -0,0 +1,42 @@ | |||
| import subprocess | |||
|
Hooray, thanks for the speedy review!
|
|
Eek,
https://travis-ci.org/conda-forge/python-chromedriver-binary-feedstock/jobs/479544384
Luckily it's Travis, and probably just needs a re-kick... I'll get to it as
soon as I can, but have intermittent network right now...
|
|
Rekicked that, good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes #12. Halfway to #1, actually, as this proposes using the conda-build machinery to download the raw binaries, and manage the shasums directly. Have also added more aggressive tests that do even more
$PATHhacking to ensure it does what is says on the tin.Also adds myself as a maintainer, as I seem to be bumping up on this package fairly frequently.