Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 10.2 #93

Merged
merged 4 commits into from
Dec 9, 2023
Merged

Upgrade to 10.2 #93

merged 4 commits into from
Dec 9, 2023

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Dec 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.
Dependencies
  • sage 10.1, Upgrade to 10.1 #94
  • sagelib 10.2 sagelib v10.2 sagelib-feedstock#165
  • Upgrade arb 2.22.1→2.23.0
  • Upgrade attrs 22.1.0→23.1.0 (indirect or distribution dependency)
  • Upgrade babel 2.11.0→2.12.1
  • Add cachetools 5.3.1 (indirect or distribution dependency)
  • Add calver 2022.6.26 (distribution dependency)
  • Upgrade certifi 2022.9.24→2023.7.22
  • Add chardet 5.2.0 (tox dependency)
  • Upgrade cmake 3.24.3→3.27.3 (indirect or distribution dependency)
  • Add colorama 0.4.6 (tox dependency)
  • Upgrade configure (indirect or distribution dependency)
  • Upgrade contourpy 1.0.6→1.1.1 (indirect or distribution dependency)
  • Upgrade cypari 2.1.3→2.1.4 needs Release v2.1.4 on PyPI sagemath/cypari2#143 and then a PR on the cypari feedstock
  • Upgrade cysignals 1.11.2→1.11.4 cysignals v1.11.4 cysignals-feedstock#50 needs Error on Python 3.12 sagemath/cysignals#195
  • Upgrade cython 0.29.32.p2→3.0.4
  • Upgrade distlib 0.3.6→0.3.7 (indirect or distribution dependency)
  • Upgrade editables 0.3→0.5 (indirect or distribution dependency)
  • Upgrade fastjsonschema 2.16.2→2.18.0 (indirect or distribution dependency)
  • Upgrade filelock 3.8.0→3.12.3 (indirect or distribution dependency)
  • Upgrade flint 2.8.4→2.9.0
  • Upgrade flit_core 3.7.1→3.9.0 (indirect or distribution dependency)
  • Upgrade fonttools 4.28.4→4.42.1 (indirect or distribution dependency)
  • Upgrade fplll 5.4.4→5.4.5
  • Upgrade fpylll 0.5.9→0.6.0
  • Upgrade gast 0.5.3→0.5.4 (indirect or distribution dependency)
  • Upgrade gc 8.0.4→8.2.4 (indirect or distribution dependency)
  • Upgrade hatch_fancy_pypi_readme 22.8.0→23.1.0 (indirect or distribution dependency)
  • Upgrade hatch_vcs 0.2.0→0.3.0 (indirect or distribution dependency)
  • Upgrade hatchling 1.11.1→1.18.0 (indirect or distribution dependency)
  • Upgrade importlib_metadata 6.0.0→6.8.0 (indirect or distribution dependency)
  • Upgrade importlib_resources 5.12.0→6.0.1 (indirect or distribution dependency)
  • Add ipympl 0.9.3 (optional)
  • Upgrade jupyter_core 4.11.2→4.12.0
  • Upgrade jupyter_sphinx 0.3.2→0.4.0.p0 (indirect or distribution dependency)
  • Upgrade kissat 3.0.0→3.1.0 (optional)
  • Upgrade kiwisolver 1.4.3→1.4.5 (indirect or distribution dependency)
  • Upgrade libatomic_ops 7.6.10→7.8.0 (indirect or distribution dependency)
  • Upgrade libbraiding 1.1→1.2 libbraiding v1.2 libbraiding-feedstock#4
  • Upgrade markupsafe 2.1.1→2.1.3 (indirect or distribution dependency)
  • Upgrade matplotlib 3.6.2→3.8.0
  • Upgrade meson 1.0.1→1.2.3 (indirect or distribution dependency)
  • Upgrade meson_python 0.12.1→0.14.0 (indirect or distribution dependency)
  • Upgrade msolve 0.4.9→0.5.0 (optional)
  • Upgrade nauty 27r1.p1→2.8.6.p1 Upgrade to version 2.8.6 nauty-feedstock#22
  • Upgrade ninja_build 1.11.0→1.11.1 (indirect or distribution dependency)
  • Upgrade normaliz 3.10.0→3.10.1 (optional)
  • Upgrade numpy 1.23.5→1.26.1
  • Upgrade onetbb 2021.7.0→2021.9.0 (optional)
  • Upgrade openblas 0.3.23→0.3.25 (done differently)
  • Upgrade openssl 3.0.8→3.0.12 (indirect or distribution dependency)
  • Upgrade packaging 21.3→23.2 (indirect or distribution dependency)
  • Upgrade pari 2.15.2.p1→2.15.4
  • Upgrade pillow 9.0.1→10.1.0
  • Upgrade pip 22.3.1→23.3.1 (indirect or distribution dependency)
  • Upgrade platformdirs 2.5.4→3.11.0 (indirect or distribution dependency)
  • Upgrade pluggy 1.0.0→1.3.0 (indirect or distribution dependency)
  • Upgrade pplpy 0.8.7→0.8.9 pplpy v0.8.9 pplpy-feedstock#14
  • Upgrade ptyprocess 0.5.1.p0→0.7.0
  • Upgrade pybind11 2.10.1→2.11.1 (indirect or distribution dependency)
  • Upgrade pyparsing 3.0.9→3.1.1
  • Add pyproject_api 1.6.1 (tox dependency)
  • Upgrade pyproject_metadata 0.6.1→0.7.1 (indirect or distribution dependency)
  • Upgrade pythran 0.12.1→0.14.0
  • Upgrade pytz 2022.5→2023.3.post1
  • Upgrade pyzmq 24.0.1→25.1.1
  • Upgrade scipy 1.10.1→1.11.3
  • Upgrade send2trash 1.8.0→1.8.2 (indirect or distribution dependency)
  • Upgrade setuptools 63.4.3→68.2.2 (indirect or distribution dependency)
  • Upgrade setuptools_scm 7.0.5→8.0.4 (indirect or distribution dependency)
  • Upgrade singular 4.3.1p3→4.3.2p8 Upgrade to 4.3.2 singular-feedstock#25
  • Upgrade tox 3.27.0→4.11.1 (indirect or distribution dependency)
  • Upgrade traitlets 5.5.0→5.9.0
  • Add trove_classifiers 2023.8.7 (hatchling dependency)
  • Upgrade typing_extensions 4.5.0→4.7.1 (indirect or distribution dependency)
  • Upgrade tzlocal 4.2→5.0.1 (indirect or distribution dependency)
  • Upgrade virtualenv 20.16.6→20.24.4 (indirect or distribution dependency)
  • Upgrade wheel 0.38.4→0.41.2 (indirect or distribution dependency)
  • Upgrade widgetsnbextension 4.0.3→4.0.8
  • Upgrade zeromq 4.3.4→4.3.5

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum saraedum changed the title 102 Upgrade to 10.2 Dec 5, 2023
@saraedum saraedum marked this pull request as draft December 5, 2023 19:24
@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2023

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/sage-feedstock/actions/runs/7124498233.

@saraedum saraedum marked this pull request as ready for review December 7, 2023 13:09
@saraedum saraedum closed this Dec 7, 2023
@saraedum saraedum reopened this Dec 7, 2023
@saraedum saraedum closed this Dec 7, 2023
@saraedum saraedum reopened this Dec 7, 2023
@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2023

Let's see if the missing upgrades are actually necessary.

saraedum added a commit to saraedum/rw-feedstock that referenced this pull request Dec 7, 2023
this blocks conda-forge/sage-feedstock#93
because the old igraph is pulling in an old version of libxml.
@saraedum saraedum closed this Dec 7, 2023
@saraedum saraedum reopened this Dec 7, 2023
@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2023

Let's try again with an updated rw.

@isuruf
Copy link
Member

isuruf commented Dec 7, 2023

File "src/sage/interfaces/singular.py", line 1265, in sage.interfaces.singular.Singular.version
Failed example:
    singular.version()
Exception raised:
    Traceback (most recent call last):
      File "$PREFIX/lib/python3.11/site-packages/sage/doctest/forker.py", line 709, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "$PREFIX/lib/python3.11/site-packages/sage/doctest/forker.py", line 1144, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.singular.Singular.version[0]>", line 1, in <module>
        singular.version()
      File "$PREFIX/lib/python3.11/site-packages/sage/interfaces/singular.py", line 1268, in version
        return singular_version()
               ^^^^^^^^^^^^^^^^^^
      File "$PREFIX/lib/python3.11/site-packages/sage/interfaces/singular.py", line 2464, in singular_version
        return singular.eval('system("--version");')
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "$PREFIX/lib/python3.11/site-packages/sage/interfaces/singular.py", line 667, in eval
        raise SingularError('Singular error:\n%s' % s)
    sage.interfaces.singular.SingularError: Singular error:
    *** stack smashing detected ***: $PREFIX/bin/Singular terminated
    Singular : signal 11 (v: 4212):
    current line:>>system("--version");<<
    Segment fault/Bus error occurred at 7fff8374f970 because of 10246 (r:101047404)
    please inform the authors
    trying to restart...
**********************************************************************

@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2023

Unsurprisingly, running system("--version"); directly in our singular works fine on my machine.

@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2023

Hm…but we pulled in singular: 4.2.1.p3-h1ea75ed_2 conda-forge instead of the latest version.

@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2023

I guess we need a singular built against an old FLINT here.

See conda-forge/singular-feedstock#26

@saraedum saraedum closed this Dec 8, 2023
@saraedum saraedum reopened this Dec 8, 2023
@saraedum
Copy link
Member Author

saraedum commented Dec 8, 2023

We wait for the migration bot to rebuild sagelib with the new version of Singular, i.e., conda-forge/sagelib-feedstock#168

@saraedum saraedum closed this Dec 8, 2023
@saraedum saraedum reopened this Dec 8, 2023
@saraedum saraedum closed this Dec 9, 2023
@saraedum saraedum reopened this Dec 9, 2023
@saraedum
Copy link
Member Author

saraedum commented Dec 9, 2023

@isuruf, I cannot reproduce the Singular error locally. Apart from that, Singular seems to work fine since lots of tests that rely on it do pass.

@saraedum saraedum merged commit c4f270b into conda-forge:main Dec 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants