-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mlflow-export-import #28135
base: main
Are you sure you want to change the base?
add mlflow-export-import #28135
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mlflow-export-import/recipe.yaml:
For recipes/mlflow-export-import/recipe.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
||
build: | ||
script: python -m pip install . -vv | ||
number: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add entrypoints for the following https://github.com/mlflow/mlflow-export-import/blob/a572e944ebee82fe9b37c5e7b35541d01c26253b/setup.py#L45-L65 as well:
https://prefix-dev.github.io/rattler-build/latest/reference/recipe_file/#python-entry-points
sha256: 336bd0fe3a16ac2198774f89d2642df5d103d306a5a6d3b48f3eed90dbddf9c3 | ||
|
||
build: | ||
script: python -m pip install . -vv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script: python -m pip install . -vv | |
script: python -m pip install . -vv | |
noarch: python |
https://prefix-dev.github.io/rattler-build/latest/tutorials/python/#a-python-only-package
- ${{ compiler('c') }} | ||
- ${{ stdlib('c') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a pure python package, you probably don't need compilers here
|
||
tests: | ||
- script: | ||
- test ${PREFIX}/include/mlflow-export-import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for testing for package contents, i would use https://prefix-dev.github.io/rattler-build/latest/reference/recipe_file/#check-for-package-contents nowadays
also, i would add some import tests for mlflow_export_import
: https://prefix-dev.github.io/rattler-build/latest/reference/recipe_file/#python-tests
- mlflow | ||
- databricks-cli ==0.18.0 | ||
- pandas >=1.5.2 | ||
- tabulate ==0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these belong in the run requirements
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mlflow-export-import/recipe.yaml:
For recipes/mlflow-export-import/recipe.yaml:
|
build: | ||
- wheel | ||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pip belongs in host, wheel in run
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/mlflow-export-import/recipe.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mlflow-export-import/recipe.yaml:
For recipes/mlflow-export-import/recipe.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/mlflow-export-import/recipe.yaml:
|
windows builds failing due to conda-forge/mlflow-feedstock#199 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).