Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mlflow-export-import #28135

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

EllaBootQC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mlflow-export-import/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/mlflow-export-import/recipe.yaml:

For recipes/mlflow-export-import/recipe.yaml:

  • Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [23].

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mlflow-export-import/recipe.yaml) and found it was in an excellent condition.


build:
script: python -m pip install . -vv
number: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha256: 336bd0fe3a16ac2198774f89d2642df5d103d306a5a6d3b48f3eed90dbddf9c3

build:
script: python -m pip install . -vv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
script: python -m pip install . -vv
script: python -m pip install . -vv
noarch: python

https://prefix-dev.github.io/rattler-build/latest/tutorials/python/#a-python-only-package

Comment on lines 19 to 20
- ${{ compiler('c') }}
- ${{ stdlib('c') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a pure python package, you probably don't need compilers here


tests:
- script:
- test ${PREFIX}/include/mlflow-export-import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 21 to 24
- mlflow
- databricks-cli ==0.18.0
- pandas >=1.5.2
- tabulate ==0.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these belong in the run requirements

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mlflow-export-import/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/mlflow-export-import/recipe.yaml:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/mlflow-export-import/recipe.yaml:

  • noarch: python recipes should almost always follow the syntax in our documentation. For the host section of the recipe, you should almost always use python {{ python_min }}.* for the python entry. You may need to override the python_min variable if the package requires a newer Python version than the currently supported minimum version on conda-forge.
  • noarch: python recipes should almost always follow the syntax in our documentation. For the run section of the recipe, you should almost always use python >={{ python_min }} for the python entry. You may need to override the python_min variable if the package requires a newer Python version than the currently supported minimum version on conda-forge.
  • noarch: python recipes should almost always follow the syntax in our documentation. For the test.requires section of the recipe, you should almost always use python ={{ python_min }} for the python entry. You may need to override the python_min variable if the package requires a newer Python version than the currently supported minimum version on conda-forge.

Comment on lines 42 to 44
build:
- wheel
- pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pip belongs in host, wheel in run

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mlflow-export-import/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mlflow-export-import/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mlflow-export-import/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/mlflow-export-import/recipe.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

For recipes/mlflow-export-import/recipe.yaml:

  • ℹ️ No valid build backend found for Python recipe for package mlflow-export-import using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mlflow-export-import/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mlflow-export-import/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@pavelzw
Copy link
Member

pavelzw commented Nov 20, 2024

windows builds failing due to conda-forge/mlflow-feedstock#199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants