Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vsgImGui #28912

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add vsgImGui #28912

wants to merge 9 commits into from

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Jan 23, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vsgImGui/meta.yaml) and found some lint.

Here's what I've got...

For recipes/vsgImGui/meta.yaml:

  • ❌ pin_compatible should be used instead of pin_subpackage for vsgImGui because it is not a known output of this recipe: ['vsgimgui'].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12939532261. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vsgImGui/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 24, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12940568043. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vsgimgui/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta marked this pull request as ready for review January 24, 2025 01:59
@jeongseok-meta
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

It seems the linter error is unrelated, as I'm seeing the same error in other PRs (e.g., this one). However, if it's not unrelated, I would appreciate any help on this.

@@ -0,0 +1,66 @@
{% set name = "vsgImGui" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter may be confused by the casing differences between the name and the run_exports.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy I am facing the same issue. A change happened yesterday approximately 24 hours ago. I tested then a meta.yaml that worked a few hours before again, it gave the new error in the linter. Therefore, I suspect something on GitHub changed that makes the linter fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm also suspicious that there might be something else that could have caused this, because it was fine with other recipes (e.g., https://github.com/conda-forge/staged-recipes/pull/28730/files#diff-907e125340dccaf73eebc0b636349abcafcff964d43b2fe8a8fd742bfa354da0R1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter error is gone rebasing to #28925!

@@ -0,0 +1,5062 @@
From 6d1dff24888a8ec3601fe0354dc94ea986a2ccb6 Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a massive diff that could also be achieved by an rm … call. Can you use that instead? This should make maintenance simpler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean running rm ... in the build script instead or in meta.yaml, which I don't know how to? Alternatively, could I handle this after the feedstock repository is created? Ideally, these patches would be submitted to upstream (vsg-dev/vsgImGui#73) and the maintainer is positive about the change, so it could be addressed upstream hopefully soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this patch and used the rm commands in the build scripts

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants