Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python3.10 and fix cross-cython #23

Closed

Conversation

erykoff
Copy link

@erykoff erykoff commented Nov 22, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This is an update to #22 that fixes the cross-compilation using a similar hack to https://github.com/conda-forge/shapely-feedstock/blob/master/recipe/build.sh#L6-L10 .

To be honest, I don't understand how or why this works, this is just cargo-culting from @isuruf 's work.

What is even more mysterious is the question of how the cross-build of zfpy ever worked in the first place. After a bunch of digging I could not figure out what changed.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@erykoff
Copy link
Author

erykoff commented Nov 22, 2021

Oh I am so sad now. This works with osx-arm64 (where I was testing it), but apparently the ppc64le failure is different.

@hmaarrfk
Copy link
Contributor

Honestly, I think FindPython needs to be updated.

Scikit-build is lagging a little on this:
LLNL/zfp#110

Why not turn off cross-compilation for ppc64le?

@beckermr
Copy link
Member

@conda-forge-admin rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the u/erykoff/python310-and-cython
branch of erykoff/zfpy-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts cannot be rerendered because of GitHub
permissions.

@beckermr
Copy link
Member

frack your silly account @erykoff

please rerender locally.

@beckermr beckermr mentioned this pull request Nov 23, 2021
@github-actions github-actions bot closed this in #22 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants