Don't build conda store cli #1019
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soapy1 marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. There are a lot of places where we use There was a problem hiding this comment. I think the amount of effort it will take to introduce a job-level variable will be pretty similar to the amount of effort it will take to explicitly rename things. Since (1) we should only be renaming But open to doing it if I'm missing an important upside that it will provide. I think it would be appropriate to do that work in a follow up PR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,28 +20,23 @@ jobs: | |
| build-package: | ||
| name: "Build & verify package" | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: conda-store-server | ||
| steps: | ||
| - name: "Checkout Repository 🛎" | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - run: echo "Running on conda-store-server" | ||
soapy1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: "Build and check package - conda-store-server 📦" | ||
soapy1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| uses: hynek/build-and-inspect-python-package@v2 | ||
| id: baipp | ||
| with: | ||
| path: conda-store-server | ||
| upload-name-suffix: "-conda-store-server" | ||
| attest-build-provenance-github: "true" | ||
|
|
||
| - run: echo Packages can be found at ${{ steps.baipp.outputs.dist }} and in artifact ${{ steps.baipp.outputs.artifact-name }} | ||
|
|
@@ -55,17 +50,11 @@ jobs: | |
| if: github.repository_owner == 'conda-incubator' && github.event_name == 'push' && github.ref == 'refs/heads/main' | ||
| permissions: | ||
| id-token: write # IMPORTANT: this permission is mandatory for trusted publishing | ||
| steps: | ||
| - name: "Download build artefacts 📥" | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: Packages-conda-store-server | ||
| path: dist | ||
|
|
||
| - run: ls -lR dist/ | ||
|
|
@@ -86,20 +75,15 @@ jobs: | |
| needs: build-package | ||
| permissions: | ||
| id-token: write # IMPORTANT: this permission is mandatory for trusted publishing | ||
| defaults: | ||
| run: | ||
| working-directory: conda-store-server | ||
|
|
||
| steps: | ||
| - name: "Download build artefacts 📥" | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: Packages-conda-store-server | ||
| path: dist | ||
|
|
||
| - name: "Upload to PyPI 🚀" | ||
|
|
@@ -114,11 +98,6 @@ jobs: | |
| needs: release-pypi | ||
| permissions: | ||
| id-token: write # IMPORTANT: this permission is mandatory for trusted publishing | ||
| steps: | ||
| - name: "Checkout Repository 🛎" | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -129,7 +108,7 @@ jobs: | |
|
|
||
| - name: "Copy .dockerignore" | ||
| run: | | ||
| cp .dockerignore conda-store-server/.dockerignore | ||
| shell: bash | ||
|
|
||
| - name: "Retrieve secret from Vault 🗝" | ||
|
|
@@ -166,8 +145,8 @@ jobs: | |
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: | | ||
| quansight/conda-store-server | ||
| quay.io/quansight/conda-store-server | ||
| tags: | | ||
| type=ref,event=tag | ||
| type=ref,event=branch | ||
|
|
@@ -176,9 +155,9 @@ jobs: | |
| - name: "Publish Docker image 🚀" | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: "conda-store-server" | ||
| target: "prod" | ||
| file: "conda-store-server/Dockerfile" | ||
| build-args: | | ||
| RELEASE_VERSION=${{github.ref_name}} | ||
| python_version=${{ env.PYTHON_VERSION_DEFAULT }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are not building the Docker image shall we also remove the Dockerfile?
There does not seem to be a reason to keep straggling files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it would be better to remove all the conda-store directory at the same time opposed to piecemeal removing pieces.