Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with cryptography>=41. #57

Merged
merged 13 commits into from
Aug 17, 2023
Merged

Improve compatibility with cryptography>=41. #57

merged 13 commits into from
Aug 17, 2023

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Jun 1, 2023

Description

Fix #56 by stop using a hack to override the subclass of the private and public key classes after it stopped working when cryptography switched to a Rust implementation in pyca/cryptography#8697.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 1, 2023
@jezdez jezdez marked this pull request as draft June 1, 2023 11:23
@jezdez jezdez marked this pull request as ready for review June 1, 2023 11:40
@jezdez jezdez changed the title Remove private class Reimplement private and public key classes following breakage from upstream API change Jun 2, 2023
@jezdez jezdez requested a review from kenodegard June 5, 2023 12:56
@rolweber
Copy link

rolweber commented Aug 8, 2023

ping?

@jezdez jezdez requested a review from kenodegard August 16, 2023 20:20
kenodegard
kenodegard previously approved these changes Aug 17, 2023
@kenodegard
Copy link
Contributor

@jezdez news?

tests/requirements.txt Outdated Show resolved Hide resolved
@jezdez jezdez changed the title Reimplement private and public key classes following breakage from upstream API change Improve compatibility with cryptography>=41. Aug 17, 2023
@jezdez jezdez merged commit c522313 into main Aug 17, 2023
14 checks passed
@jezdez jezdez deleted the cryptography-41 branch August 17, 2023 18:07
@rolweber
Copy link

Thank you!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

conda-content-trust is incompatible with cryptography=41.0.0
4 participants