Increase test coverage for signing module. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
reviewed
Aug 17, 2023
Comment on lines
+132
to
+134
| assert set(repodata["packages"].keys()) | set( | ||
| repodata["packages.conda"].keys() | ||
| ) == set(repodata_signed["signatures"].keys()) |
There was a problem hiding this comment.
does this mean v1 and v2 packages have identical signatures?
Suggested change
| assert set(repodata["packages"].keys()) | set( | |
| repodata["packages.conda"].keys() | |
| ) == set(repodata_signed["signatures"].keys()) | |
| assert { | |
| *repodata["packages"].keys(), | |
| *repodata["packages.conda"].keys(), | |
| } == set(repodata_signed["signatures"].keys()) |
There was a problem hiding this comment.
Looks like it means the keys are the same but not the values.
dholth
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
[ ] Add a file to thenewsdirectory (using the template) for the next release's release notes?[ ] Add / update outdated documentation?