Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest benchmark #95

Merged
merged 14 commits into from
Sep 29, 2023
Merged

Add pytest benchmark #95

merged 14 commits into from
Sep 29, 2023

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Sep 5, 2023

Description

Results so far:

  • new checkformat-hex-string is much faster than older version
  • checking signatures (generating a new PublicKey each time) is half as fast as re-using the PublicKey each time

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@dholth dholth marked this pull request as draft September 5, 2023 17:09
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 5, 2023
@@ -328,7 +329,6 @@ def interactive_modify_metadata(metadata):
"and prettier printing of JSON, you may install pygments."
)
pygments = None
from pprint import pprint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter change

@dholth dholth linked an issue Sep 12, 2023 that may be closed by this pull request
2 tasks
@beeankha beeankha mentioned this pull request Sep 12, 2023
2 tasks
@beeankha
Copy link
Member

pre-commit.ci autofix

tests/test_benchmark.py Outdated Show resolved Hide resolved
@dholth dholth marked this pull request as ready for review September 28, 2023 18:22
@dholth
Copy link
Contributor Author

dholth commented Sep 28, 2023

Let's merge this.

One way to approach this project would be to continue adding benchmarks until we run out of functions in conda-content-trust, but we should be able to merge any individual PR before reaching that level.

@dholth dholth merged commit 380c790 into main Sep 29, 2023
18 checks passed
@dholth dholth deleted the add-pytest-benchmark branch September 29, 2023 13:24
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add benchmarks
5 participants