Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to output file with installer hashes #816

Merged
merged 13 commits into from
Jul 30, 2024

Conversation

marcoesters
Copy link
Contributor

Description

Add option to output hashes of installer file. The file format is written in a way that it can be verified with shasum -c and similar UNIX tools.

In order to work with installer_type: all (see issue #814), I merged the info objects before creating outputs. I'm not sure if that closes the issue, but it's a temporary workaround.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 1, 2024
@marcoesters marcoesters marked this pull request as ready for review July 1, 2024 22:58
@marcoesters marcoesters requested a review from a team as a code owner July 1, 2024 22:58
@marcoesters marcoesters requested review from a team and removed request for a team July 1, 2024 22:58
@jaimergp
Copy link
Contributor

jaimergp commented Jul 2, 2024

LGTM but I wonder if the output files should be one per installer, named as {installer-name}-{version}.{extension}.{algorithm}; e.g. for Miniconda-24.5.0_py310.sh we would find SHA256 in Miniconda-24.5.0_py310.sh.sha256. I'm thinking of these files published next to the installers in Miniforge, for example.

@marcoesters
Copy link
Contributor Author

LGTM but I wonder if the output files should be one per installer, named as {installer-name}-{version}.{extension}.{algorithm}; e.g. for Miniconda-24.5.0_py310.sh we would find SHA256 in Miniconda-24.5.0_py310.sh.sha256. I'm thinking of these files published next to the installers in Miniforge, for example.

I think that makes sense since users will download only one installer and then shasum -c would fail. I used the entire filename for simplicity though, which Miniforge does as well.

jaimergp
jaimergp previously approved these changes Jul 3, 2024
@marcoesters marcoesters merged commit 3bb0fd4 into conda:main Jul 30, 2024
18 checks passed
@marcoesters marcoesters deleted the checksum-files branch September 3, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants