Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ServiceMonitor labels are now properly rendered and customizable #122

Merged
merged 4 commits into from
Oct 17, 2024
Merged

fix: ServiceMonitor labels are now properly rendered and customizable #122

merged 4 commits into from
Oct 17, 2024

Conversation

qboileau
Copy link
Member

  • Fix rendering of Console ServiceMonitor labels
  • Add missing labels and annotation override on Gateway ServiceMonitor
  • Add override for Gateway ServiceMonitor jobLabel
  • Update Gateway bitnami-common dependency
  • Add chart linting to pre-commit githook

BStarmerSmith
BStarmerSmith approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@BStarmerSmith BStarmerSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really like some of the QOL changes made.

@qboileau qboileau merged commit 2db983a into main Oct 17, 2024
3 checks passed
@qboileau qboileau deleted the fix-service-monitor-labels branch October 17, 2024 07:48
This was referenced Nov 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BStarmerSmith BStarmerSmith BStarmerSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qboileau @BStarmerSmith