Gateway Chart: Support nameOverride support in grafana templates #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json called GATEWAY_NAME so you can now rename the var easily. Also added this to grafana-dashboard.yaml.
…nto cus-334-six-nameoverride-support-in-grafana-template
…nto cus-334-six-nameoverride-support-in-grafana-template
BStarmerSmith
deleted the
cus-334-six-nameoverride-support-in-grafana-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously hardcoding the value conduktor-gateway into the grafana template causing issues when you overrided what you wanted to name your gateway implementation as it would not load all the grafana template data. This PR fixes this by adding an input into our grafana templates.
I also added makefile examples for building out the correct version of the grafana operator to use on gateway since our grafana template is outdated.