Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't install uefi deps on s390x podvm builds #2235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Jan 13, 2025

There are no UKI tools for s390x packaged in ubuntu at the moment, thus we have to split this out. s390x will not attempt to build UEFI images, so we don't need those tools for an mkosi build on that platform.

There are no UKI tools for s390x packaged in ubuntu at the moment, thus
we have to split this out. s390x will not attempt to build UEFI images,
so we don't need those tools for an mkosi build on that platform.

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke requested a review from a team as a code owner January 13, 2025 11:05
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry I didn't spot these added in the previous PR.

@mkulke
Copy link
Collaborator Author

mkulke commented Jan 13, 2025

I took the liberty to the updated workflow on this repo to leverage to the s390x runner. it seems to work: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12745991124/job/35521109158

@stevenhorsman stevenhorsman requested a review from BbolroC January 13, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants