Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibmcloud-powervs: fix timeout creating PowerVS (DHCP request) #2252

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

squarti
Copy link
Contributor

@squarti squarti commented Jan 20, 2025

This PR ensures that the timeout used to wait the VM to be active is not used for getting the VM ip.

Fixes: #2177

@squarti squarti requested a review from a team as a code owner January 20, 2025 17:28
@stevenhorsman
Copy link
Member

@squarti - we are missing DCO sign-off here.

This PR ensures that the timeout used to wait the VM to be active
is not used for getting the VM ip.

Fixes: confidential-containers#2177

Signed-off-by: Silenio Quarti <[email protected]>
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevenhorsman stevenhorsman merged commit d4c66df into confidential-containers:main Jan 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibmcloud-powervs: DHCP timeout too short
3 participants