Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podvm: Fix debug image build issue on s390x #2260

Merged

Conversation

yoheiueda
Copy link
Member

This patch fixes the debug image build issue on s390x.

Currently, I cannot build a debug podvm image on s390x. The following command just build a production podvm image.

sudo make image-debug

I guess this issue was revealed by this recent change.

6e25be3#diff-0578158244ea494f1ad5e1970ee5560d1cf6bfc62fd70243bd3a46280a237a14

This patch fixes the issue that debug pod VM image for s390x is not properly built.

Signed-off-by: Yohei Ueda <[email protected]>
@yoheiueda yoheiueda requested a review from a team as a code owner January 23, 2025 07:11
Copy link
Collaborator

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, that’s a typo and on an unknown profile it‘ll default to production, thx for catching it.

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevenhorsman stevenhorsman merged commit 4020f29 into confidential-containers:main Jan 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants