CI Documentation - Add AMD nodes and labels to jobs table #317
Conversation
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
d7ce14c
to
0aa1da9
Compare
|
hi @ryansavino , I think that a separated table only to map label -> machine would be better. |
|
lgtm; wainer's comment is fine, too, if you think it would help |
|
Looks good to me as is in the single table (it's not that wide) although I'm having troubles actually finding the pipeline definitions (tried searching for the name as well as the labels). Are they supposed to be already there? |
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
2 times, most recently
from
8efd6ad
to
daacda4
Compare
|
I've updated this PR with the machine table as well. @wainersm let me know what you think. I can add other system labels if you guys know what they are. @BbolroC @stevenhorsman @fidencio Question: default CcRuntime is referring to runtime class? Should I add that column in the job table? @ldoktor the AMD nodes are already labeled. |
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
daacda4
to
87d7b94
Compare
The added machine table links the machine's assigned labels to the jobs required labels. Signed-Off-By: Ryan Savino <[email protected]>
Added the snp and sev machines and jobs to the table with their required and assigned labels. Fixes: confidential-containers#316 Signed-Off-By: Ryan Savino <[email protected]>
Signed-Off-By: Ryan Savino <[email protected]>
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
87d7b94
to
0e23b73
Compare
ryansavino
requested review from
portersrc,
fitzthum,
fidencio and
AdithyaKrishnan
Please, if possible, do.
So, for the TDX machine the label is |
docs: added column for labels to the CI jobs table
docs: Added snp and sev job names and labels to CI documentation
Fixes: #316
Signed-Off-By: Ryan Savino [email protected]