Fixup some database problems #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue was the later bullseye images didn't support openssl v3 for some reason: 1.80 may be okay though. Also, docker hub images. Unfortunately, rust doesn't have a container image anywhere else besides docker hub. @arvindskumar99 you have any additional insights here from your notes? I remember you having some issues recently with the simple-kbs. |
Our old version of sqlx has some compatibility issues with mariadb, so we've got to upgrade. Upgrading requires some messing around due to upstream bugs. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
The new version of sqlx requires a new version of rust. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
the versions field is no longer needed Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
The variable set in this test script does not match the one we use in the CI. Let's adjust. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
|
Still ironing out some issues with upgrading sqlx. There were a lot of changes between v0.5.0 and v0.8.0 |
fitzthum
force-pushed
the
sqlx-080
branch
2 times, most recently
from
6e516b1
to
32025cf
Compare
Updating sqlx broke our policy insertion. Unfortunately we have to adopt some backend-specific logic. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
With the udpate to sqlx, we are no longer able to transparently convert SQL BLOBS (such as longtext) to Rust strings when using the mysql driver. Add some branches to convert these into bytes first and then to strings. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
|
Ok, issues appear to be ironed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #64
Upgrading sqlx was not as simple as I would have liked.
@ryansavino I am bumping the version of Rust which you pinned in our builder container a while ago. Do you think that's going to break things?