td-layout: move payload to the start of image file #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the payload is loaded into physical memory rather than the ROM space, image-rom mapping of other regions will not be affected if payload is at the start of the image file. Signed-off-by: Jiaqi Gao <[email protected]>
As the payload is moved to the beginning part of the image and is no longer adjacent to B, so the metadata section needs to be modified according to two cases: 1. If `exec-payload-section` feature is set, load payload in `Payload` section. 2. If the feature is not set, load payload into another `BFV` section. Signed-off-by: Jiaqi Gao <[email protected]>
|
This is not what we have discussed. |
The reason is adding a new section bring lots of changes in implemetation:
For the metadata offset issue we have discussed, two approaches use the same way to locate the metadata: So I think moving the payload section to the begining of image file will be a better approach in implementation. Do you have any concern on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the payload is loaded into physical memory rather than the ROM space, image-rom mapping of other regions will not be affected if payload is at the start of the image file.