td-shim-interface: support large ffs and section #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
May 10, 2024
| @@ -38,17 +38,6 @@ pub fn read_fv_header(fv_data: &[u8]) -> Option<FirmwareVolumeHeader> { | |||
| Some(header) | |||
| } | |||
|
|
|||
| // Validate Ffs File header | |||
| pub fn validate_ffs_file_header(header: FfsFileHeader) -> bool { | |||
jyao1
reviewed
May 10, 2024
| @@ -264,14 +263,6 @@ impl FfsFileHeader { | |||
| self.integrity_check.file = FFS_FIXED_CHECKSUM; | |||
| self.state = EFI_FILE_HEADER_CONSTRUCTION | EFI_FILE_HEADER_VALID | EFI_FILE_DATA_VALID; | |||
| } | |||
|
|
|||
| // Validate the checksum of the FfsFileHeader | |||
| pub fn validate_checksum(&self) -> bool { | |||
gaojiaqi7
force-pushed
the
0509/support_large_ffs_and_section
branch
3 times, most recently
from
1b5000f
to
d344cf6
Compare
Align the definition, implementation and derive of the `FfsFileHeader2` and `CommonSectionHeader2` with `FfsFileHeader` and `CommonSectionHeader`. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0509/support_large_ffs_and_section
branch
from
d344cf6
to
b604ca0
Compare
Add support for parsing ffs and sections that have size larger than 16MiB. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0509/support_large_ffs_and_section
branch
from
b604ca0
to
1cef3d8
Compare
jyao1
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.