Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KGLOBAL-5631: CLI to only have one column of "Remote Cluster Id" and remove "Destination Cluster Id" and "Source Cluster Id" for list link #2901

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

KGLOBAL-5631: CLI to only have one column of "Remote Cluster Id" and remove "Destination Cluster Id" and "Source Cluster Id" for list link #2901

wants to merge 4 commits into from
+16 −24

Conversation

luyixiao12
Copy link
Member

@luyixiao12 luyixiao12 commented Oct 8, 2024 •
edited
Loading

Release Notes

Bug Fixes

This is a minor bug for our list link command
JIRA ticket: https://confluentinc.atlassian.net/browse/KGLOBAL-5631

  • For list link, since destination cluster and local cluster is not useful, we only show remote cluster in this case
  • TODO: we want to revise the describe link as well.

Checklist

  • Leave this box unchecked if features are not yet available in production

What

References

Test & Review

luyixiao12 and others added 2 commits October 8, 2024 12:54
@luyixiao12
add
c3455f9
@luyixiao12
Merge pull request #137 from confluentinc/KGLOBAL-5631-v2
bfa9a1b 
KGLOBAL-5631: CLI to only have one column of "Remote Cluster Id" and remove "Destination Cluster Id" and "Source Cluster Id" for list link
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@luyixiao12 luyixiao12 marked this pull request as ready for review October 9, 2024 05:21
@luyixiao12 luyixiao12 requested a review from a team as a code owner October 9, 2024 05:21
sgagniere
sgagniere requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing output fields is a breaking change, so we'll need to wait for v5 for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgagniere sgagniere sgagniere requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luyixiao12 @sgagniere