Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDATA-8616 Apply Confluent Patches on top of Druid 30.0.1 #268

Merged
merged 15 commits into from
Feb 3, 2025

Conversation

suraj-goel
Copy link
Member

@suraj-goel suraj-goel commented Jan 22, 2025

Description

  • Added the confluent specific patches on top of Druid - 30.0.1
  • Fixed the code and unit test cases of the patches as per druid-30

Release note

Druid 30 Release Note - Ref

Testing

  • Built the project locally (including Unit test cases locally)
  • Created a Docker Image and deployed it on Druid stag and Druid stag-358af
    • OpenSearch logs doesn't have any errors

Manual Changes Required for an upgrade an existing cluster

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suraj-goel suraj-goel marked this pull request as ready for review January 27, 2025 08:14
@ravisharm
Copy link
Member

"Manual Changes Required for an upgrade an existing cluster"
I dont think above section applies to us as we are building a new Druid cluster with 30.0.1 image. We are not upgrading Druid 25.0 running on Prodeks.

@suraj-goel
Copy link
Member Author

"Manual Changes Required for an upgrade an existing cluster" I dont think above section applies to us as we are building a new Druid cluster with 30.0.1 image. We are not upgrading Druid 25.0 running on Prodeks.

Yes, @ravisharm.
Added as these changes were required in stag environments.

ravisharm
ravisharm previously approved these changes Jan 29, 2025
Copy link
Member

@ravisharm ravisharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed off for the rowsScanned and cpu metrics part.

@ravisharm
Copy link
Member

While testing pls ensure below metrics show on Datadog:
query/planningTime
rowsScanned

@suraj-goel
Copy link
Member Author

While testing pls ensure below metrics show on Datadog: query/planningTime rowsScanned

Yes, Tested these metrics are coming in DD.

@ravisharm
Copy link
Member

signed off on latest commit
2146672

@suraj-goel suraj-goel merged commit e92ab77 into 30.0.1-confluent Feb 3, 2025
2 checks passed
@suraj-goel suraj-goel deleted the druid-30-with-confluent-patches branch February 3, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants