Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kafka REST, SR and message consumer APIs using direct connections #141

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

rhauch
Copy link
Contributor

@rhauch rhauch commented Nov 4, 2024

Summary of Changes

Modified the ClusterStrategyProcessor and ConsumeStrategyProcessor implementations to support proxying requests to Kafka and SR clusters defined on direct connections.

Limitations: the status on direct connections does not yet reflect the ability to connect (see #123), and direct connections do not yet have authentication credentials (see #124).

Also slightly refactors the ITs for these APIs that run against local connections, so that we can easily run these tests against local connections and direct connections.

Resolves #122

Pull request checklist

Please check if your PR fulfills the following (if applicable):

  • Tests:
    • Added new
    • Updated existing
    • Deleted existing
  • Have you validated this change locally against a running instance of the Quarkus dev server?
    make quarkus-dev
  • Have you validated this change against a locally running native executable?
    make mvn-package-native && ./target/ide-sidecar-*-runner

… connections

Resolves #122

Modified the `ClusterStrategyProcessor` and `ConsumeStrategyProcessor` implementations to support proxying requests to Kafka and SR clusters defined on direct connections.

Limitations: the `status` on direct connections does not yet reflect the ability to connect (see #123), and direct connections do not yet have authentication credentials (see #124).
@rhauch rhauch requested a review from a team as a code owner November 4, 2024 21:17
Copy link
Contributor

@rohitsanj rohitsanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was super satisfying to review.

Adding 100s of new tests simply by extending some abstract base test classes?! Oh goodness, it's fantastic.

@rhauch rhauch merged commit 3065672 into main Nov 4, 2024
1 check passed
@rhauch rhauch deleted the use-direct-connections-in-proxy-apis branch November 4, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using direct connections in Kafka REST, Message Consumer, and SR API endpoints
2 participants