Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy HTTP request headers from VS Code #99

Merged

Conversation

rohitsanj
Copy link
Contributor

@rohitsanj rohitsanj commented Oct 21, 2024

Summary of Changes

Include all headers passed from VS Code when proxying requests to a target Kafka/SR cluster, except for sidecar-specific headers (specified as config in application.yml).

Resolves #92

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

  • Tests:
    • Added new
    • Updated existing
    • Deleted existing
  • Have you validated this change locally against a running instance of the Quarkus dev server?
    make quarkus-dev
  • Have you validated this change against a locally running native executable?
    make mvn-package-native && ./target/ide-sidecar-*-runner

@rohitsanj rohitsanj requested a review from a team as a code owner October 21, 2024 23:42
rhauch
rhauch previously approved these changes Oct 22, 2024
Copy link
Member

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitsanj rohitsanj marked this pull request as draft October 22, 2024 17:44
@rhauch rhauch self-requested a review October 22, 2024 17:44
@rohitsanj rohitsanj marked this pull request as ready for review October 22, 2024 20:25
@jlrobins
Copy link

Worked with Rohit and fixed some issues found in clicktesting. We wrote #102 in the process thereof.

But this works better than before now. Can now POST to create a schema consistently now that content-type header is making it through to ccloud.

@rohitsanj rohitsanj merged commit 4c52157 into main Oct 22, 2024
1 check passed
@rohitsanj rohitsanj deleted the rohitsanj/92-from-vscode-http-request-headers-should-be-proxied branch October 22, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From-vscode HTTP request headers should be proxied
3 participants