Skip to content

Commit

Permalink
MINOR: Upgrade gradle to 6.8 and test retry plugin to 1.2.0 (apache#9849
Browse files Browse the repository at this point in the history
)

Also fix generation of `gradlew` when `APP_HOME` contains a directory with spaces
in its name.

Release notes:
* https://docs.gradle.org/6.8/release-notes.html
* https://github.com/gradle/test-retry-gradle-plugin/releases/tag/v1.2.0

In addition to existing tests, verified that `./gradlewAll jar` succeeds.

Reviewers: Chia-Ping Tsai <[email protected]>
  • Loading branch information
ijuma authored Jan 18, 2021
1 parent 8648643 commit 1ca497a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ versions += [
bcpkix: "1.66",
checkstyle: "8.20",
commonsCli: "1.4",
gradle: "6.7.1",
gradle: "6.8",
gradleVersionsPlugin: "0.36.0",
grgit: "4.1.0",
httpclient: "4.5.12",
Expand Down Expand Up @@ -115,7 +115,7 @@ versions += [
spotbugs: "4.1.4",
spotbugsPlugin: "4.6.0",
spotlessPlugin: "5.8.2",
testRetryPlugin: "1.1.9",
testRetryPlugin: "1.2.0",
zinc: "1.3.5",
zookeeper: "3.5.8",
zstd: "1.4.5-12"
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
4 changes: 2 additions & 2 deletions gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ esac

# Loop in case we encounter an error.
for attempt in 1 2 3; do
if [ ! -e "$APP_HOME"/gradle/wrapper/gradle-wrapper.jar ]; then
if ! curl -s -S --retry 3 -L -o "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" "https://raw.githubusercontent.com/gradle/gradle/v6.7.1/gradle/wrapper/gradle-wrapper.jar"; then
if [ ! -e "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" ]; then
if ! curl -s -S --retry 3 -L -o "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" "https://raw.githubusercontent.com/gradle/gradle/v6.8.0/gradle/wrapper/gradle-wrapper.jar"; then
rm -f "$APP_HOME/gradle/wrapper/gradle-wrapper.jar"
# Pause for a bit before looping in case the server throttled us.
sleep 5
Expand Down
2 changes: 1 addition & 1 deletion wrapper.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ task bootstrapWrapper() {
def bootstrapString = """
# Loop in case we encounter an error.
for attempt in 1 2 3; do
if [ ! -e $wrapperJarPath ]; then
if [ ! -e "$wrapperJarPath" ]; then
if ! curl -s -S --retry 3 -L -o "$wrapperJarPath" "$wrapperJarUrl"; then
rm -f "$wrapperJarPath"
# Pause for a bit before looping in case the server throttled us.
Expand Down

0 comments on commit 1ca497a

Please sign in to comment.