Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tombstoned metric to JMX #3166

Open
wants to merge 3 commits into
base: 7.7.x
Choose a base branch
from
Open

Add tombstoned metric to JMX #3166

wants to merge 3 commits into from

Conversation

Claimundefine
Copy link
Contributor

@Claimundefine Claimundefine commented Jun 27, 2024

Adding metric for when schemas are hard deleted. These metrics do not overlap with soft-deleted metrics.

It should be mentioned that the original ticket was to add soft-delete metric, but in fact the missing metric is hard deletes. Note that soft delete count >= hard delete count, since the schema must be soft deleted first.

Testing
Added test cases, as well as manually running requests.

FAQ:

What happens when a soft deleted schema gets restored then deleted again?

Soft deleted schemas pertaining to a subject can be retrieved with the deleted=true flag, which allows you to find the deleted schema and recreate it using the same definition. However, this creates a new version for the subject, and does not map to the old version.

What about the workaround to restore hard-deleted schemas?

It is difficult to tell when a hard-deleted schema is restored, since it is recreated using the same definition then manually mapped to a schema id. These are separate operations that cannot definitively be mapped to restoring a hard-deleted schema.

@Claimundefine Claimundefine requested a review from a team as a code owner June 27, 2024 23:27
Copy link

cla-assistant bot commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jun 27, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant