Fixed or-tools install script #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the right diagnosis, but I am not sure if the solution is ok. AFAIK: DYLD_LIBRARY_PATH is a colon separated list of directories that contain libraries. So not necessarily a single value. We have BIN_DIR controlling where the binaries should end up in, with ~/.local/bin as it's default value. Maybe we need a LIB_DIR env var as well controlling where the shared libs should end up in? Does anybody know what the done thing is here I wonder? Maybe @ott2? PS: DYLD_LIBRARY_PATH on macos LD_LIBRARY_PATH on linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have noticed that, in some Linux systems, the script to install or-tools wasn't working properly: the compilation was successful but at, execution time, the Or-tools solver would throw an exception because it could not locate a shared library it needed. The library was present but it was located in the binary directory and not in the shared library directory. To fix this issue, I have added an if statement that checks if the shared binary folder is present and if it is, the libraries will be copied there. I have also added a message to inform the user on how to act in case the solver doesn't work.