Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with 'make generate' #819

Merged
merged 1 commit into from
Feb 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ generate: $(BIN)/buf $(BIN)/protoc-gen-go $(BIN)/protoc-gen-connect-go $(BIN)/li
cd internal/conformance && go mod tidy
rm -rf internal/gen
PATH="$(abspath $(BIN))" buf generate
( cd cmd/protoc-gen-connect-go; ./generate.sh )
( cd cmd/protoc-gen-connect-go; PATH="$(abspath $(BIN)):$$PATH" ./generate.sh )
license-header \
--license-type apache \
--copyright-holder "The Connect Authors" \
Expand Down
2 changes: 1 addition & 1 deletion cmd/protoc-gen-connect-go/generate.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
find testdata -maxdepth 1 -type d \( ! -name testdata \) -exec bash -c "cd '{}' && buf generate" \;
find testdata -maxdepth 1 -type d \( ! -name testdata \) | xargs -n 1 -I % bash -c "cd '%' && buf generate"

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

56 changes: 43 additions & 13 deletions cmd/protoc-gen-connect-go/testdata/diffpackage/diffpackage.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

56 changes: 43 additions & 13 deletions cmd/protoc-gen-connect-go/testdata/noservice/noservice.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading