meowlflow/serve: reuse app to inherit config #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the serve command instantiates its own FastAPI app, without any of the configuration used in the sidecar.py module. This is a problem because we miss out on the middleware and metrcs. This commit changes the serve.py module so that it reuses the existing app. Signed-off-by: Lucas Servén Marín <[email protected]>
dswah
approved these changes
Dec 16, 2021
|
ah dang some build error. im on mobile so i cant see the error |
|
just had to retry and it worked we seem to be hitting something like this bug in Kaniko: GoogleContainerTools/kaniko#1592 Maybe we can switch from Kaniko to https://github.com/genuinetools/img |
|
nice work u little mergy guy!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the serve command instantiates its own FastAPI app, without
any of the configuration used in the sidecar.py module. This is a
problem because we miss out on the middleware and metrcs. This commit
changes the serve.py module so that it reuses the existing app.
Signed-off-by: Lucas Servén Marín [email protected]