More events for observability #732
Conversation
fendermint/app/src/app.rs
Outdated
| hash = request.hash.to_string(), | ||
| proposer = request.proposer_address.to_string() |
There was a problem hiding this comment.
Any reason we don't add these fields to the accepted event as well? We could refactor this into a single emit.
There was a problem hiding this comment.
I was thinking we dont really care who proposed it if accepted, we can get that from cometbft. But reject, we might want to know who. As for two events, I think it was because it's tracked as two events so no extra filtering needed.
There was a problem hiding this comment.
For diagnostics, it's useful to know who you accepted a proposal from explicitly. That allows you to identify patterns when performing diagnostics/forensics. Also: let's err on the side of spitting out more information, we can always reduce the verbosity later. It also simplifies the code and involves less entropy.
Adding more events for: