-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topdown lost commits #757
Topdown lost commits #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the code being simplified. Could you provide some description of what exactly changed? What replaces the pointers, why were they needed before but not any more?
Co-authored-by: Akosh Farkash <[email protected]>
Co-authored-by: Akosh Farkash <[email protected]>
…yard/ipc into topdown-lost-commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I couldn't explain why it should be faster, though 🤔
Recover lost fendermint topdown commits from previous archived repo. Some major changes includes:
sync_many
flag from mainBack then the requirement was only pushing the parent view to cache if the next block is a non-null block. In this case, we need to track:
We were using a head and tail to pull data.
Now we dont have this requirement, we just need the latest height fetched in cache to determine the next height to poll. The data is pushed to cache regardless if it's null or non-null. This way it simplifies the logic.