Added a function that reads a key with cursor hidden #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think solving this on windows will be a pain, likewise killing the program by sending a signal in is also going to bypass this. I wonder now if it would not be better to provide an API to just reset the terminal to a reasonable default on shutdown with a utility function and to encourage people to use this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed API to read a key with cursor hidden. This would make the common case of cursors disappearing on ctrl-c less common as this is the most common case right now where cursors are hidden.
So rather than hiding cursors all the time, this would hide the cursor just while waiting for the key press and reset it afterwards.
Refs console-rs/dialoguer#294