Accept items by iterator instead of slice #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the handling for adding multiple items to the
Select
,FuzzySelect
,MultiSelect
, andSort
they currently take a slice containing any number of values that can be converted intoString
throughToString
, this change replaces taking a slice with instead taking anything that implementIntoIterator
where the item isToString
.This allows the items function to take any collection of values rather than only allowing slices, thus making something like the following possible:
Changes
items
,items_checked
(and similar functions) accept an iterator instead of a slice