-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zero Touch Satellite Registration #54
base: main
Are you sure you want to change the base?
Changes from 21 commits
899cff5
5ea9a9c
1e37033
c9db9bc
87dc798
41cd4d9
e6611db
471130a
63bbe5a
f0ff18a
106dc68
2ccd213
a1d7827
524285f
ee7b3b2
14b0d18
ab3befd
880b5b3
13781f4
db8fcf1
ca26bdd
7dbfc0f
3d030dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,12 @@ | ||
# Source Registry | ||
HARBOR_USERNAME=admin | ||
HARBOR_PASSWORD=Harbor12345 | ||
HARBOR_URL=https://demo.goharbor.io | ||
HARBOR_URL=https://registry.bupd.xyz | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Security: Avoid committing credentials to version control The file contains hard-coded admin credentials for Harbor registry. This poses a significant security risk, especially since it's pointing to what appears to be a production URL. Consider:
-HARBOR_USERNAME=admin
-HARBOR_PASSWORD=Harbor12345
+HARBOR_USERNAME=<your-username>
+HARBOR_PASSWORD=<your-password>
|
||
|
||
# ZOT Registry | ||
ZOT_URL="127.0.0.1:8585" | ||
|
||
# Ground Control PORT | ||
PORT=8080 | ||
APP_ENV=local | ||
Comment on lines
+9
to
11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Environment configuration inconsistency The file mixes production URLs (registry.bupd.xyz) with local environment settings (APP_ENV=local), which could lead to accidental production data manipulation during development. Consider:
-APP_ENV=local
+APP_ENV=production # or keep local and change HARBOR_URL to local
|
||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security: Use HTTPS for ground control communication.
The default ground control URL uses HTTP, which is insecure for satellite communication. Consider:
📝 Committable suggestion