Fix Export adapter #45
Conversation
adds adapter
Adds the registry URL to the state artifact file instead of its name
Signed-off-by: bupd <[email protected]>
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
stage.go should not change, it has an impact on other adapters, preventing them from working.
| log.Debugf("assembling dest resources...") | ||
|
|
||
| // Check condition to determine whether to assemble list or destination resources | ||
| if policy.DestRegistry.Type == "artifact-list-export" { |
There was a problem hiding this comment.
I see some debug print statements left in the code. But the most important thing is that such PR won't be accepted by the community of Harbor. We can't place such a switcher inside of core logic.
|
There is some issue at the replication at |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
state artifactIssue being fixed
Fixes #(issue)
Please indicate you've done the following: