fix: add solaris to non-supported shim. #84
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jperkin, for the failing CI check could you sign the commit. Check out this link https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work for the details. |
Signed-off-by: Jonathan Perkin <[email protected]>
|
Done, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This completes the removal of solaris support, and ensure that those of us on illumos can continue to build projects such as minio that depend on this module. Tested both on macOS via
GOOS=solaris GOARCH=amd64as well as natively on illumos.If anyone is interested I also have initial native support for illumos at https://github.com/jperkin/console/tree/illumos but as per my commit there I'm at a bit of an impasse. I'll leave that for another day.
Thanks!