Part 6: enable windows unit test #3546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
part6
branch
7 times, most recently
from
2f6e503 to
e92e453
Compare
apostasie
commented
Oct 16, 2024
| @@ -39,6 +42,17 @@ jobs: | |||
| go-version: ${{ env.GO_VERSION }} | |||
| check-latest: true | |||
| cache: true | |||
| - if: ${{ matrix.goos=='windows' }} | |||
There was a problem hiding this comment.
Some tests depend on CNI being installed.
apostasie
commented
Oct 16, 2024
| @@ -38,7 +38,7 @@ func TestParseVolumeOptions(t *testing.T) { | |||
| vType: "bind", | |||
| src: "dummy", | |||
| optsRaw: "rw", | |||
| wants: []string{}, | |||
There was a problem hiding this comment.
Either the code or the test should be changed.
I am opting for changing the test.
apostasie
force-pushed
the
part6
branch
2 times, most recently
from
4d4e613 to
0c6b778
Compare
|
Re-run failures are: TestLogsWithInheritedFlags for Docker - already spotted as flaky with Docker before - is the test broken or is docker broken? |
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
|
Failure is fixed with #3563 |
|
Geez. Closing was not what I meant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is marking a few tests as flaky.
Second commit enables unit testing for windows.
Depends on:
Changes to make the tests pass (besides above PRs):
See inline comments.
Leaving as draft until the dependencies are merged.