Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOMScoreAdj is incorrectly cleared even if no plugin performs an adjustment #117

Closed
samuelkarp opened this issue Oct 23, 2024 · 2 comments · Fixed by #116 or containerd/containerd#10884
Closed

OOMScoreAdj is incorrectly cleared even if no plugin performs an adjustment #117

samuelkarp opened this issue Oct 23, 2024 · 2 comments · Fixed by #116 or containerd/containerd#10884
Labels
bug Something isn't working

Comments

@samuelkarp
Copy link
Member

From kubernetes/kubernetes#128251, and see the new failing unit test in #116.
@samuelkarp samuelkarp mentioned this issue Oct 23, 2024
Closed
@samuelkarp samuelkarp added the bug Something isn't working label Oct 23, 2024
@samuelkarp samuelkarp mentioned this issue Oct 23, 2024
Merged
samuelkarp added a commit to samuelkarp/nri that referenced this issue Oct 23, 2024
@samuelkarp
generate: do not set OOMScoreAdj if no adjustment
555a15b 
Existing OOMScoreAdj on the incoming spec should not be cleared.

Fixes containerd#117

Signed-off-by: Samuel Karp <[email protected]>
@samuelkarp samuelkarp mentioned this issue Oct 23, 2024
Merged
@mikebrow
Copy link
Member

@klihub FYI

samuelkarp added a commit to samuelkarp/nri that referenced this issue Oct 23, 2024
@samuelkarp
generate: do not set OOMScoreAdj if no adjustment
b5fc359 
Existing OOMScoreAdj on the incoming spec should not be cleared.

Fixes containerd#117

Signed-off-by: Samuel Karp <[email protected]>
@samuelkarp samuelkarp reopened this Oct 23, 2024
@samuelkarp
Copy link
Member Author

samuelkarp commented Oct 23, 2024 •
edited
Loading

Leaving this open to track the remainder of the work:

samuelkarp added a commit to samuelkarp/containerd that referenced this issue Oct 23, 2024
@samuelkarp
deps: bump github.com/containerd/nri
5362d4a 
Fixes containerd/nri#117

Signed-off-by: Samuel Karp <[email protected]>
@samuelkarp samuelkarp mentioned this issue Oct 23, 2024
Merged
samuelkarp added a commit to samuelkarp/containerd that referenced this issue Oct 23, 2024
@samuelkarp
deps: bump github.com/containerd/nri
4b9d6c0 
Fixes containerd/nri#117

Signed-off-by: Samuel Karp <[email protected]>
@klihub klihub mentioned this issue Oct 24, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
containerd v2 blockers
Status: Done
Milestone
No milestone
2 participants
@samuelkarp @mikebrow