generate: do not set OOMScoreAdj if no adjustment #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
changed the title
|
/cc @mikebrow |
Existing OOMScoreAdj on the incoming spec should not be cleared. Fixes containerd#117 Signed-off-by: Samuel Karp <[email protected]>
The generator should not clear an existing OOMScoreAdj if no adjustment is performed. Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
force-pushed
the
oom-score-adj
branch
from
555a15b
to
07bfc18
Compare
|
i’m fine with not being able to unset for now.. we can figure that out in a follow up, after we ensure we are not accidentally unsetting ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing OOMScoreAdj on the incoming spec should not be cleared.
Fixes #117