Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: verify that code generation works and results match #113

Merged
merged 1 commit into from
Oct 1, 2024
Merged

ci: verify that code generation works and results match #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,22 @@ jobs:
run: |
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH

- name: Install protoc and plugins
run: |
sudo make install-protoc
make install-protoc-dependencies install-ttrpc-plugin

- name: Force regeneration of protobuf files on build
run: |
touch pkg/api/api.proto

- run: |
make all

- name: Validate files in git have not been changed
run: |
make validate-repo-no-changes

linters:
name: Linters
runs-on: ${{ matrix.os }}
Expand Down
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ vet:
golangci-lint:
$(Q)$(GOLANG_CILINT) run

validate-repo-no-changes:
$(Q)test -z "$$(git status --short | tee /dev/stderr)" || { \
echo "Repository has changes."; \
echo "Please make sure to commit all changes, including generated files."; \
exit 1; \
}

#
# proto generation targets
#
Expand Down
Loading