-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up golang to 1.22.0 #132
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| module github.com/containerd/nri/examples | ||
|
|
||
| go 1.18 | ||
| go 1.22.0 | ||
|
|
||
| require ( | ||
| github.com/containerd/cgroups v1.0.3 | ||
| github.com/containerd/nri v0.1.0 | ||
| github.com/opencontainers/runtime-spec v1.0.3-0.20220825212826-86290f6a00fb | ||
| github.com/sirupsen/logrus v1.8.1 | ||
| github.com/sirupsen/logrus v1.9.3 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/coreos/go-systemd/v22 v22.3.2 // indirect | ||
| github.com/docker/go-units v0.4.0 // indirect | ||
| github.com/godbus/dbus/v5 v5.0.4 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| golang.org/x/sys v0.13.0 // indirect | ||
| golang.org/x/sys v0.21.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/containerd/nri => ../ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/containerd/nri/plugins/differ | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| require ( | ||
| github.com/containerd/nri v0.6.1 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/containerd/nri/plugins/logger | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| require ( | ||
| github.com/containerd/nri v0.6.1 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/containerd/nri/plugins/template | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| require ( | ||
| github.com/containerd/nri v0.6.1 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/containerd/nri/plugins/wasm | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| require github.com/containerd/nri v0.6.1 | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Copyright The containerd Authors. | ||
|
|
||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
|
|
||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # | ||
| # Run go mod tidy in all go modules | ||
| # | ||
| set -eu -o pipefail | ||
|
|
||
| find . -name go.mod | while read -r gomod; do | ||
| dir=$(dirname "$gomod") | ||
|
|
||
| pushd "$dir" | ||
| go mod tidy | ||
| popd | ||
| done |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a specific need to raise the minimum required version? Go modules use minimum versions selection; that includes the go versions, and for library modules should specify the absolute minimum that can be used. eg golang's x/sys and others still allow go1.18, because the did not require anything more current; https://github.com/golang/sys/blob/d4ac05dc8c4c953ec29cae3df56c0833f4010763/go.mod#L3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thaJeztah thanks for review and suggestion. (moved PR to draft for now since need to fix CI errors)
There is no required need for this go update. It's mainly to make our dependency upgrade easier. E.g., from my experiment, both
google.golang.org/grpcandk8s.io/cri-apiupdates require go 1.22 at least. I probably can find a relatively new version for them that still only requires go 1.21.That being said, I'm happy to change it back to go 1.21 and update those deps to the versions that only requires go 1.21. :)
I assume we still want to keep the versions in plugins to be up-to-date (e.g., at least uses a non-EOL version if possible)? E.g., keep
./go.modat minimum, and update./plugins/*/go.modrelatively frequently?Meanwhile, a few clarification questions on go/deps around containerd projects:
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roughly yes, though a couple thoughts on this:
No, but we definitely should test it (in CI) at a version in sync with containerd.