-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take pkg/hooks from github.com/containers/common #46
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 64.38% 64.38%
=======================================
Files 9 9
Lines 1800 1800
=======================================
Hits 1159 1159
Misses 495 495
Partials 146 146 ☔ View full report in Codecov by Sentry. |
Pls sign commits with real name and email. Cheers! |
@@ -30,7 +30,7 @@ import ( | |||
|
|||
"github.com/containerd/nri/pkg/api" | |||
"github.com/containerd/nri/pkg/stub" | |||
"github.com/containers/podman/v3/pkg/hooks" | |||
hooks "github.com/containers/common/pkg/hooks/1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT this does not compile if imported like this. I think it should be without /1.0.0
, simply as
"github.com/containers/common/pkg/hooks"
Like it's done here in cri-o.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok done that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the new import path and update your commit (to be signed) according to @mikebrow 's instructions.
@eclipseo wave.. |
e0d547f
to
7d8edfd
Compare
Ok fixed the import path and signed the commit. |
363853f
to
ea3e4ba
Compare
I did do a |
1179ead
to
b9a67cd
Compare
pkg/hooks was moved from github.com/containers/podman/v4 to github.com/containers/common and it's to much time consuming to keep packaging github.com/containers/podman/v3. Signed-off-by: Robert-André Mauchin <[email protected]>
b9a67cd
to
d708940
Compare
I gave it a quick go to carry the change in #55 changes compared to this PR; rebase (we merged the "remove containerd dependency" |
Replaced by #55. |
pkg/hooks was moved from github.com/containers/podman/v4 to github.com/containers/common and it's to much time consuming to keep packaging github.com/containers/podman/v3.