Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: shim: Complete the metrics collection for cgroup v1 #275

Closed
wants to merge 1 commit into from

Conversation

zzzzzzzzzy9
Copy link
Contributor

Complete the metrics collection for cgroup v1 so that containerd can obtain complete metrics information

@github-actions github-actions bot added the C-shim Containerd shim label May 27, 2024
@zzzzzzzzzy9 zzzzzzzzzy9 changed the title <feature> shim: Complete the metrics collection for cgroup v1 Feature: shim: Complete the metrics collection for cgroup v1 May 27, 2024
@zzzzzzzzzy9
Copy link
Contributor Author

@mxpv

@zzzzzzzzzy9
Copy link
Contributor Author

@Burning1020

@Burning1020
Copy link
Member

Got you. Will review it...

@mxpv mxpv requested a review from Burning1020 June 5, 2024 00:33
@Mossaka
Copy link
Member

Mossaka commented Jun 5, 2024

I think it's great to have a complete cgroupv1 stats collection, but given #258 suggests that the complex logic of cgroups stats should not reside in the shim crate, I would recommend that we should take a look at if libcgroups could be of use.

In particular, libcgroups maintained by youki has cgroups v1 and v2 StatsProvider (source), so we don't need to duplicate the effort in this repo.

I am fully aware that we are using cgroups-rs, so what I am proposing here is to evaluate whether or not libcgroups satisfies our requirements and can replace cgroups-rs.

CC @utam0k

@utam0k
Copy link
Member

utam0k commented Jun 7, 2024

I'm happy to collaborate with you if possible!

@zzzzzzzzzy9 zzzzzzzzzy9 force-pushed the dev branch 2 times, most recently from 715056b to 5a2d5c2 Compare June 14, 2024 09:18
@mxpv
Copy link
Member

mxpv commented Jun 17, 2024

Hey @Mossaka, can you give a bit more context on cgroups-rs vs libcgroups ?

@mxpv
Copy link
Member

mxpv commented Dec 13, 2024

Thanks for your work on this! Since the long-term plan is to remove cgroups from the shim crate (see #258), I’m going to close this PR.

@mxpv mxpv closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-shim Containerd shim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants