-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnitool: deduplicate environment variable definitions #926
base: main
Are you sure you want to change the base?
Conversation
This looks basically reasonable, but any of the environment variables that are |
fb89176
to
55e376e
Compare
i have moved all furthermore i have moved the CNI Args parsing logic into |
55e376e
to
c8fd9aa
Compare
|
||
// supported CNI_COMMAND values | ||
|
||
CmdAdd = "ADD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pkg/env
is supposed to be a tool package, is it better to place this constants on another package, maybe pkg/constants
?
c8fd9aa
to
42aa09f
Compare
create a reusable package for environment variables to be used by `cnitool` and the other library code. Signed-off-by: Gordon Bleux <[email protected]>
42aa09f
to
99bb7b3
Compare
create a reusable package for environment variable to be used by
cnitool
and the other library code.Signed-off-by: Gordon Bleux [email protected]