enhancement(ci): Add release docker image

[leojonathanoh]

This adds a multiarch docker image, based on previous work in #245.

Since I'm not an approved collaborator on this repo with read access to repository secrets, the CI will not be able to login to Docker Hub and push images. To show it works, I'm building the same branch on my fork PR to demonstrate that it works. leojonathanoh#1

TODO

• Dockerfile to build CNI plugins. Bonus points for playing nice with dependabot.
• Multiarch Dockerfile for released "installer" image
• Fixup release.sh to use this (or some equivalent)
• Build releases automatically via GitHub and push them to ghcr
• Cosign all the things! (might need validation)

Implements #806

Signed-off-by: Leonard Jonathan Oh [email protected]

[squeed]

The question here is, basically, should we build / push on merge? Right?

My first thought is: sure, why not? As long as we aren't bumping the latest tag.

[leojonathanoh]

EDIT: yes, this pushes only on main and tags.

[squeed]

This looks awesome! Thanks so much for taking this on!

I have a few small requests, but they're just the cherry on top. If you've got time, that'd be great, but I really want to get this in.

(p.s. this needs a signed-off-by :-) )

[squeed]

Also, looks like the new yamllint is mad at something :-p

[leojonathanoh]

EDIT: yes, this pushes only on main and tags.

[leojonathanoh]

Do i have to signoff all commits? Or just in the PR body?

[squeed]

Do i have to signoff all commits? Or just in the PR body?

All commits :-).

[squeed]

But we should squash this down to one or two commits before merging.

[s1061123]

You may need LABEL command to specify some of label, as github document mentioned, such as org.opencontainers.image.source

As I worked similar stuff in another repo, this org.opencontainers.image.source is required.

[leojonathanoh]

Thanks for the tip. Any recommendation on which LABELs to add?

[leojonathanoh]

managed to add all the org.opencontainers.image.xxx labels, hope i didn't miss anything.

[leojonathanoh]

All commits :-).

But we should squash this down to one or two commits before merging.

will squash it down and sign once the PR is done :)

[leojonathanoh]

oh yes, I was wondering about how to tie the release CI process with this docker image's binaries, so there is one source of binaries as discussed in #245 (comment). Can't seem to find out how the release process goes as far as looking around.

[leojonathanoh]

squashed my commits down and signed off. i'm not sure what to do with whether previous work should be signed off too?

[squeed]

@leojonathanoh can you rebase on main and squash to a single commit please? Then we can get this awesome PR merged!

[leojonathanoh]

sure, i'll do this tomorrow when i manage to get some time.

[onedr0p]

Any update on this PR @squeed ? Squash and merge and release 🚀

[onedr0p]

@leojonathanoh looks like you might need to rebase and fix any conflicts since it's taken this long for a merge :/

[leojonathanoh]

Sure 😄

[leojonathanoh]

Passed on my fork, see leojonathanoh#1, where I have fork secrets that don't work on the CI here.

Before merging, will need to remove the code marked with TODO in the CI files.

[onedr0p]

It's unfortunate that this as been pending so long, it seems like the maintainers are ignoring this or don't find value in this PR 😭

[leojonathanoh]

it's fine 😄 perhaps it will get merged. Guess not many in the community need a docker image for updating plugins 😬

[MikeZappa87]

@leojonathanoh hello, sorry things get lost in the shuffle! The best way is to join the weekly sync and put an item on the agenda! Sorry for the delay!

[micw]

it's fine 😄 perhaps it will get merged. Guess not many in the community need a docker image for updating plugins 😬

Hello,

I was the author of the initial request (#245). After a few years I'm back to "multus-cni" and had the hope this is meanwhile merged :-(
Just wanted you to know that this is one of the use cases where a docker image of the plugins would be really helpful.

[leojonathanoh]

it's fine 😄 perhaps it will get merged. Guess not many in the community need a docker image for updating plugins 😬

Hello,

I was the author of the initial request (#245). After a few years I'm back to "multus-cni" and had the hope this is meanwhile merged :-( Just wanted you to know that this is one of the use cases where a docker image of the plugins would be really helpful.

Thanks for your previous work. Hope to see this merged too 😄

[onedr0p]