Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kargs: Introduce usage of fs_utf8 #676

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

cgwalters
Copy link
Collaborator

This avoids annoyances with constantly checking for utf-8.

lib/src/kargs.rs Outdated Show resolved Hide resolved
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters
Copy link
Collaborator Author

I'm going to redo this on top of coreos/cap-std-ext#53 once it's released

This avoids annoyances with constantly checking for utf-8.
Also the new `filenames_filtered_sorted` API we added
to cap-std-ext is more concise and efficient.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

I'm going to redo this on top of coreos/cap-std-ext#53 once it's released

Done ✔️

@cgwalters cgwalters marked this pull request as ready for review July 16, 2024 17:05
@jmarrero jmarrero self-requested a review July 16, 2024 17:31
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit 89635a8 into containers:main Jul 16, 2024
19 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants