Merge pull request #247 from cgwalters/readlinkat-overflow

writer: Fix (almost certainly unreachable) overflow
containers · Feb 5, 2024 · 091b51f · 091b51f
2 parents 232336d + 6b2192b
commit 091b51f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/libcomposefs/lcfs-writer.c b/libcomposefs/lcfs-writer.c
@@ -689,7 +689,7 @@ struct lcfs_node_s *lcfs_load_node_from_file(int dirfd, const char *fname,
 	} else if ((sb.st_mode & S_IFMT) == S_IFLNK) {
 		char target[PATH_MAX + 1];
 
-		r = readlinkat(dirfd, fname, target, sizeof(target));
+		r = readlinkat(dirfd, fname, target, sizeof(target) - 1);
 		if (r < 0)
 			return NULL;