Merge pull request #261 from eriksjolund/add-missing-node-unref

lib: Add missing lcfs_node_unref()
containers · Mar 19, 2024 · d5ffbeb · d5ffbeb
2 parents 9c393a4 + 4e0b147
commit d5ffbeb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/libcomposefs/lcfs-writer-erofs.c b/libcomposefs/lcfs-writer-erofs.c
@@ -1211,8 +1211,10 @@ static int add_overlay_whiteouts(struct lcfs_node_s *root)
 		}
 
 		res = lcfs_node_add_child(root, child, name);
-		if (res < 0)
+		if (res < 0) {
+			lcfs_node_unref(child);
 			return res;
+		}
 	}
 
 	return 0;

diff --git a/libcomposefs/lcfs-writer.c b/libcomposefs/lcfs-writer.c
@@ -1212,8 +1212,10 @@ static struct lcfs_node_s *_lcfs_node_clone_deep(struct lcfs_node_s *node,
 		if (new_child == NULL)
 			return NULL;
 
-		if (lcfs_node_add_child(new, new_child, child->name) < 0)
+		if (lcfs_node_add_child(new, new_child, child->name) < 0) {
+			lcfs_node_unref(new_child);
 			return NULL;
+		}
 	}
 
 	return steal_pointer(&new);
@@ -1349,6 +1351,7 @@ struct lcfs_node_s *lcfs_build(int dirfd, const char *fname, int buildflags,
 		r = lcfs_node_add_child(node, n, de->d_name);
 		if (r < 0) {
 			errsv = errno;
+			lcfs_node_unref(n);
 			goto fail;
 		}
 	}